Would I be counting this bar out correctly?
 

Where I added the count for 4/4 time?

This is a segment of two bars of a practice piece that alternates between strumming and melody lines.

I want to keep the strumming hand in an up and down motion, even where there are no notes or chords, which sadly is fairly new to me as I didn't originally learn it that way. I learned almost all fingerpicking. But I am correcting that!

https://i.imgur.com/fRtxcKLm.png

Looks like the way I learned to count it.

Look right to me. In 4/4: a stemmed hollow note head is 2 beats (1-and-2-and), a stemmed and dotted solid note head is 1.5 beats (3-and-4) and a stemmed solid note head with a flag is 0.5 beats (-and).

I would count the half note as 1 & 2 & ...the dotted 1/4 note 3& 4...the 8th note just &,
but it has been an awfull long time since I had a teacher looking over my shoulder saying no count it like this, my thinking is the way you have counted gives the impression that the 4th beat is silent like a rest but it's not it's a continuation of the note played on the 3rd beat.

You are correct.

The way I work these out is to imagine a metronome set to click every 8th note in a 4 beat bar, the half note gets 4 clicks, the dotted 1/4 note 3 clicks, the final 8th note 1 click = 8 clicks and all clicks need to be counted.

Thank you for your comments!

I agree with counting it as:


1&2&3&4&

I think you are right especially since the "&" tells me that is when my hand comes up with a ghost strum.

This is the exact right way to read that measure, musically it's very clear.

Always count by the smallest increment you'll play or sing, which is usually an 8th note, occasionally a 16th note if really fast and syncopated. Clapping out the beat is usually easier than strumming it, if you need to get the groove first.

Thanks! Great tips although strumming muted strings works well for me for getting the groove.

Good deal. Muted strums are good for grooving period.

Your next mission, should you choose to accept it: The Bo Diddley beat. https://en.wikipedia.org/wiki/Bo_Diddley_beat